Skip to content

Update Artifacts endpoint with enum security-metrics#2814

Open
ppadti wants to merge 1 commit into
kubeflow:mainfrom
ppadti:security-metrics
Open

Update Artifacts endpoint with enum security-metrics#2814
ppadti wants to merge 1 commit into
kubeflow:mainfrom
ppadti:security-metrics

Conversation

@ppadti

@ppadti ppadti commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

This PR aims to update the artifacts endpoint - mainly updating the enum to include the security-metrics and update the mocks

How Has This Been Tested?

Curl cmd to get only security-metrics:

curl -s -H 'kubeflow-userid: user@example.com' 'http://localhost:4000/api/v1/model_catalog/sources/sample-source/artifacts/repo1/granite-8b-code-instruct?namespace=kubeflow&filterQuery=metricsType.string_value=%22security-metrics%22' | python3 -m json.tool

cmd to get all artifacts:

curl -s -H 'kubeflow-userid: user@example.com' 'http://localhost:4000/api/v1/model_catalog/sources/sample-source/artifacts/repo1/granite-8b-code-instruct?namespace=kubeflow' | python3 -m json.tool

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: ppadti <ppadti@redhat.com>
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ppadti. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

metricsType:
type: string
example: “accuracy-metrics”
description: An artifact type representing a collection of related metrics, which will either be “performance-metrics” or “accuracy-metrics”.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small point here, I think is ok to keep the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants